Skip to content

feat: emit audit config condition events#1517

Open
MaxRink wants to merge 2 commits into
mondoohq:mainfrom
MaxRink:feat/auditconfig-condition-events
Open

feat: emit audit config condition events#1517
MaxRink wants to merge 2 commits into
mondoohq:mainfrom
MaxRink:feat/auditconfig-condition-events

Conversation

@MaxRink

@MaxRink MaxRink commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • wire an EventRecorder into the MondooAuditConfig reconciler
  • emit Kubernetes Events when MondooAuditConfig conditions are added or change status/reason/message
  • add Events RBAC and fake-recorder tests for warning/normal condition events

Tests

  • make manifests
  • go test ./controllers -run 'TestRecordConditionEvents|TestMondooAuditConfigStatus|TestTokenRegistration' -count=1
  • go test ./controllers/... -count=1
  • git diff --check

@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

mondoo-code-review[bot]
mondoo-code-review Bot reviewed Jun 15, 2026
View reviewed changes

@mondoo-code-review mondoo-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes events are now emitted when MondooAuditConfig conditions change, improving observability.

Comment thread controllers/mondooauditconfig_controller.go
Comment thread controllers/mondooauditconfig_controller.go
@MaxRink

MaxRink commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

I have read the Mondoo CLA Document and I hereby sign the CLA

mondoo-code-review[bot]
mondoo-code-review Bot previously approved these changes Jun 15, 2026
View reviewed changes

@mondoo-code-review mondoo-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audit config condition events now correctly skip noise from initial healthy conditions and use the updated object reference.

Comment thread controllers/mondooauditconfig_controller.go Outdated
mondoo-code-review[bot]
mondoo-code-review Bot approved these changes Jun 15, 2026
View reviewed changes

@mondoo-code-review mondoo-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes events are now emitted when MondooAuditConfig conditions change, improving observability.

mondoo-code-review[bot]
mondoo-code-review Bot previously approved these changes Jun 15, 2026
View reviewed changes

@mondoo-code-review mondoo-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment-only clarification; no functional change.

@MaxRink

MaxRink commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

/review

@MaxRink

MaxRink commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 4efddab. ± Comparison against base commit 70733ca.

♻️ This comment has been updated with latest results.

@MaxRink MaxRink force-pushed the feat/auditconfig-condition-events branch from eb382a7 to ff0e011 Compare June 19, 2026 02:51
@MaxRink MaxRink marked this pull request as draft June 19, 2026 06:13
@MaxRink MaxRink marked this pull request as ready for review June 19, 2026 08:15
@MaxRink MaxRink force-pushed the feat/auditconfig-condition-events branch from 63172be to 4efddab Compare June 19, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mondoo-code-review mondoo-code-review[bot] mondoo-code-review[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MaxRink